Remove TSRM/tsrm_config.w32.h #4383
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The tsrm_config.w32.h file is a simple wrapper for already defined symbols and includes elsewhere.
cmb69
reviewed
Jul 10, 2019
|
Hello, I've also checked extensions out there and there shouldn't be any among the widely adopted ones. This is actually following the #4090 and is an intermediate step towards making configuration headers a bit simpler to manage - related to unriddling #4371 Basically extensions should by design include php.h file (so it is system independent) and then configuration header dedicated to the extension itself and the given host environment at hand. I think this shouldn't cause any issues out there. |
nikic
approved these changes
Jul 10, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The tsrm_config.w32.h file is a simple wrapper for already defined symbols and includes elsewhere.